[Webkit-unassigned] [Bug 12901] [S60] Browser ask permission for unsecure item load repeatedly

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12901


yongjun.zhang at nokia.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13399|review?(yongjun.zhang at nokia.|review-
               Flag|com)                        |




------- Comment #3 from yongjun.zhang at nokia.com  2007-02-27 09:24 PDT -------
(From update of attachment 13399)
I think the patch is incorrect:
1. maintaining iNonSecureItemShown in both CWebKitLoader and CHttpLoader is
redundant.
2. add global flags in WebKitLoader for this purpose is generally not a good
idea.
3. In CHttpLoader::CheckSecurityStatus, the patch only considered one senario
when a secure page requests insecure subresources.  How about a insure page
requests multiple secure sburesources. The ESecureItemInNonSecurePage   dialog
will show up multiple times.

the patch is rejected based on abovementioned reasons.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.