[Webkit-unassigned] [Bug 12876] Gdk improvements

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12876


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13357|review?                     |review+
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-02-24 00:26 PDT -------
(From update of attachment 13357)
+                StringImpl *txt = new StringImpl("Welcome to Gdk Web
Browser");

   I know this is commented out, but you can just allocate this on the stack.

 #include "PlatformString.h"

+#include "ResourceHandleManager.h"

   No need for the newline between these two.

+    if (!str || !*str)
+        return true;
+    return false;

   This can just be:

return !str || !*str;

     if (0 == strcmp(str1, str2))
-        return 1;
-    return 0;
+        return true;
+    return false;

   Similar comment here.

+    GtkWidget *topLevelWindow = gtk_window_new(GTK_WINDOW_TOPLEVEL);

   You've got a misplaced * here.

+    gFrame = new FrameGdk(page, 0, frameLoaderClient);

   This can also be on the stack.

   r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.