[Webkit-unassigned] [Bug 12854] New: Allow FrameLoaderClient to override navigator.appVersion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 22 03:30:34 PST 2007


           Summary: Allow FrameLoaderClient to override navigator.appVersion
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: public at oscarc.net

Currently, navigator.appVersion is set to everything after the slash in the
userAgent. Normally, this is sufficient, but there are two circumstances where 
it is desirable to change this behavior:

* If the client wants a FireFox-style appVersion. Unlike IE, FireFox does not
derive its appVersion from its userAgent.

* If the client wants to send a different appVersion for certain web sites for
compatibility reasons. I am aware of at least one commercial browser that has
an appVersion "exceptions" list for sites that insist on a particular

The attached patch allows FrameLoaderClient to set the appVersion in the same
way it currently sets userAgent.

To avoid breaking existing FrameLoaderClient implementations, I added the
existing logic for deriving appVersion from the FrameLoaderClient class, so
FrameLoaderClient subclasses that don't override the navigatorAppVersion method
will get the current behavior. If it would be preferable to keep
FrameLoaderClient pure virtual and update all FrameLoaderClient subclasses or
if there is some better way to avoid breaking existing subclasses, I'll update
the patch.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list