[Webkit-unassigned] [Bug 12686] REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 21 17:16:24 PST 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #13306|review?                     |review-
               Flag|                            |

------- Comment #9 from darin at apple.com  2007-02-21 17:16 PDT -------
(From update of attachment 13306)
I believe this patch is incorrect. The constructor objects should return true
for implementsHasInstance, but actual DOM element instances should not.

Thus I think the implementsHasInstance function should be in the constructor
class definition inside CodeGeneratorJS.pm. It can go right above the
implementsConstruct function.

To minimize the total amount of code inside CodeGeneratorJS.pm, we might want
to make a DOMConstructor base class to inherit from. That's not needed to fix
this bug, but I do see a reasonable amount of code that could be moved out of
the auto-generation script, including:

    1) the setPrototype call in the constructor
    2) the getValueProperty member function
    3) the implementsConstruct member function
    4) the implementsHasInstance member function

But I'm not sure it's worth it.

We use spaces for indenting, not tabs. The patch has a number of tabs in it.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list