[Webkit-unassigned] [Bug 12515] Plug-ins that draw through the Quickdraw interface fail in a CGBitmapContex.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12515


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13265|review?                     |review-
               Flag|                            |




------- Comment #11 from darin at apple.com  2007-02-20 11:40 PDT -------
(From update of attachment 13265)
Needs a ChangeLog entry.

This identifier is missing a "t": WKCGContextIsBitmapContex

Adding things to WebKitSystemInterface is something that needs to be handled
internally at Apple, so I don't think it's appropriate to have it here in an
open source patch! You need to work with someone on my team -- please contact
Oliver Hunt.

Are you sure we don't want the "forUpdate" logic when the target is a
CGBitmapContext? I'm concerned that we'll end up drawing outside the damaged
area in that case -- I think the logic applies equally well to the
CGBitmapContext case, but there may be something I'm missing.

+            SetGWorld(qdPortState->oldPort, NULL);
             SetPort(qdPortState->oldPort);

Do we really need both the SetGWorld call and the SetPort call? My QuickDraw is
a little rusty, but I don't think that's right. I seem to recall that in the
old days you had to separately save and restore the port and the gdevice, and
SetGWorld would set both.

How is the TSMEventHandler change related to this bug? It doesn't seem to have
anything to do with CGBitmapContext.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.