[Webkit-unassigned] [Bug 12214] REGRESSION: css image with relative path is not loaded, when both base element and dir attribute in the html tag are present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 14 09:00:02 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12214


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13156|review?                     |review+
               Flag|                            |




------- Comment #13 from darin at apple.com  2007-02-14 08:59 PDT -------
(From update of attachment 13156)
Given our discussion of @import, I'm surprised you didn't also add @import
tests.

+        m_elemSheet.get()->setHref(m_baseURL);

I mentioned in the last review that you didn't need a get() here. Was there a
reason you didn't remove it?

Change looks fine, r=me, but I get a strange sense that you didn't pay
attention to my comments last time!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list