[Webkit-unassigned] [Bug 12123] REGRESSION: Incomplete repaint of floats' overflows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12123


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13050|                            |review?
               Flag|                            |
  Attachment #12907|0                           |1
        is obsolete|                            |




------- Comment #14 from mitz at webkit.org  2007-02-08 03:46 PDT -------
Created an attachment (id=13050)
 --> (http://bugs.webkit.org/attachment.cgi?id=13050&action=view)
Assign painting of overflowing floats to the parent

(In reply to comment #12)
> Seems like you should rename  repaintOverhangingFloats to
> repaintOverflowingFloats, since it now repaints both potentially.

Done.

> Please add flexible box tests for both the horizontal and vertical directions.

Done.

> Please add tests for inline blocks and inline tables.

Done. The inline block case is failing and I don't have a fix for it in this
patch. The problem is that if I hand over the inline block's floats to the
outer block then the painting order is wrong. I think the right way to fix the
inline block case is to include the floats' overflow in the root line box's
overflow, but I didn't want to do it in this patch (the simplest test case for
this is broken in Safari 2, so it's not a regression).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.