[Webkit-unassigned] [Bug 12160] Linux/Gdk build fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12160


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13022|review?                     |review+
               Flag|                            |




------- Comment #40 from aroben at apple.com  2007-02-08 02:05 PDT -------
(From update of attachment 13022)
 #include "ChromeClient.h"
+#include "Shared.h"

   Shared.h shouldn't be necessary anymore.

+    // FIXME: optimize the way CursorQt is optmized: only one copy of a given
+    // cursor type
+    static Cursor c = gdk_cursor_new(GDK_LEFT_PTR);

   I think you've already implemented this FIXME. Since c is static
gdk_cursor_new will only be called once.

 #include <assert.h>
 #include <gdk/gdk.h>
+#include "SystemTime.h"

   SystemTime.h should go above <assert.h>

+    m_shiftKey = event->button.state & GDK_SHIFT_MASK != 0;
+    m_ctrlKey = event->button.state & GDK_CONTROL_MASK != 0;
+    m_altKey = event->button.state & GDK_MOD1_MASK != 0;
+    m_metaKey = event->button.state & GDK_MOD2_MASK != 0;

   The '!= 0' is redundant in each of these cases.

   r=me.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.