[Webkit-unassigned] [Bug 12123] REGRESSION: Incomplete repaint of floats' overflows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12123


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12907|review?                     |review-
               Flag|                            |




------- Comment #12 from hyatt at apple.com  2007-02-07 15:47 PDT -------
(From update of attachment 12907)
Ok, I think conceptually this is good.  I have a slight concern about
performance in that you removed some hasOverhangingFloats() checks in favor of
simply always walking the floating objects list.  This means all the floats
that don't overhang or overflow are being examined all the time now.

Seems like you should rename  repaintOverhangingFloats to
repaintOverflowingFloats, since it now repaints both potentially.

Please add flexible box tests for both the horizontal and vertical directions.

Please add tests for inline blocks and inline tables.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.