[Webkit-unassigned] [Bug 12463] WebArchiver - attempt to insert nil exception when archive empty iframe
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 4 22:27:57 PST 2007
http://bugs.webkit.org/show_bug.cgi?id=12463
ddkilzer at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #12789|review+ |review-
Flag| |
------- Comment #25 from ddkilzer at webkit.org 2007-02-04 22:27 PDT -------
(From update of attachment 12789)
>- [subframeArchives addObject:[self _archiveCurrentStateForFrame:childFrame]];
>+ WebArchive *childFrameArchive = [self archiveFrame:childFrame];
>+ if (childFrameArchive)
>+ [subframeArchives addObject:childFrameArchive];
This is wrong for two reasons:
1. The new code does not match the behavior of the old code.
2. This code doesn't exhibit the same problem that the archiveFrame: method
does. After the page is loaded, the iframe contains "about:blank" when the
WebArchiver archives the page, so there will never be an attempt to add nil to
an NSMutableArray.
Darin, I need to extend DRT to make this fix testable. The current method name
is dumpAsWebArchive(), but I need two methods, one that dumps the current DOM
into a webarchive (which is the current behavior) and one that dumps the
original source into a webarchive.
I'm thinking of: dumpDOMAsWebArchive() and dumpSourceAsWebArchive() or
dumpFrameAsWebArchive(). Any opinions?
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list