[Webkit-unassigned] [Bug 12566] [Drosera] Console history fixups

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12566


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12911|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-02-04 18:17 PDT -------
(From update of attachment 12911)
Seems to me we should be looking at keypress events, not keydown or keyup,
since it's keypress events that actually change the contents of an input
element. To process after the key is hit, we could perhaps listen for the input
element's "change" event and keep a global variable to indicate what keypress
is being processed.

+    if(event.keyCode != 38 && event.keyCode != 40 && event.keyCode != 13) {

We put spaces between if and ( characters.

+    historyDisplay.scrollTop = history.scrollHeight;

This looks wrong to me. I think you want historyDisplay.scrollHeight here.

review- just because of the scrollHeight mistake.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.