[Webkit-unassigned] [Bug 6626] Arabic & Farsi rendered with no shaping (all glyphs separate, unreadable!)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 4 18:08:08 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=6626


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12920|review?                     |review+
               Flag|                            |




------- Comment #18 from darin at apple.com  2007-02-04 18:08 PDT -------
(From update of attachment 12920)
+            if (isArabicLamWithAlefLigature(source[shapingEnd]) &&
source[shapingEnd + 1] == ' ')
+                foundLigatureSpace = true;

It's more efficient and probably clear enough to just make this an assignment
rather than an if statement.

+    m_charBuffer = (UChar*)(font->isSmallCaps() ? new UChar[m_run.length()] :
0);

Why do we need a type cast here?

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list