[Webkit-unassigned] [Bug 12515] Plug-ins that draw through the Quickdraw interface fail in a CGBitmapContex.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 2 15:07:10 PST 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #12885|review?                     |review-
               Flag|                            |

------- Comment #7 from darin at apple.com  2007-02-02 15:07 PDT -------
(From update of attachment 12885)
All the trailing space stripping in this patch makes it unnecessarily hard to
review. Lets do that in a separate patch either before or after this one.

What is this new ALLOW_QUICKDRAW_OFFSCREEN_DRAWING flag? Why would it ever be

+// We would like to simply say:
if(CGBitmapContextGetBitmapInfo(currentContext)) {...}
+// however using the public API in the documented and approved way to check
+// for an CGBitmapContext, will log a warning to stdout if it's not a bitmap
+// ...So we cheat a little bit.
+enum ContextType_priv { PrivateCGBitmapContextType = 4 };
+extern ContextType_priv CGContextGetType(CGContextRef c);

It's not really OK to put this kind of thing into WebCore. If something like
this is necessary we do it in WebKitSystemInterface.

Why is it OK to bypass all the clipping logic? It looks like the new code path
ignores clipping and will ask the plug-in to paint too much each time which
will presumably hurt performance.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list