[Webkit-unassigned] [Bug 12287] Patch: make most of Frame platform independent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 2 10:44:28 PST 2007


lars at trolltech.com changed:

           What    |Removed                     |Added
  Attachment #12881|                            |review?
               Flag|                            |

------- Comment #10 from lars at trolltech.com  2007-02-02 10:44 PDT -------
Created an attachment (id=12881)
 --> (http://bugs.webkit.org/attachment.cgi?id=12881&action=view)
new version

Sorry about the length of the patch. It's a bit because of timezone issues that
make it hard for me to get an intermediate review of smaller pieces. 

Added the 0 pointer check for page and used d->m_editor throughout Frame.cpp.
Also removed all tabs that sneaked in.

I agree that windowScriptObject should have a different name. I'm not changing
it now, as I currently don't have access to a mac.

And: I would very much vote for having the same coding style in C++ and objc.
anything else is highly confusing.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list