[Webkit-unassigned] [Bug 16669] autotools update and fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16669


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #8 from jmalonzo at gmail.com  2007-12-31 14:47 PDT -------
(In reply to comment #6)

Hi Darin. Thanks for the reply.

> While I'm sure that there are some extra #if statements that aren't needed
> around some includes, I thinkt he pattern is that we put the guards in the
> header files, not at the include sites.

This is what confused me. dom/Document.cpp is a good example of this.

> I'd appreciate following one consistent approach. I think the current one is
> the "in the header file" approach and should be changed to be consistently
> that.

May I ask, what are the reasons why guards are put in the header files instead
of in the include sites?

> We need to do that work if possible. Putting the VPATH into a different file
> would be fine.

Ok. There's already a bit of discussion on this but no definite plan yet on
when it will happen. 

Thanks again.

Reopening the bug for patch submission as per outcome of this discussion. 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.