[Webkit-unassigned] [Bug 16669] autotools update and fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16669





------- Comment #6 from darin at apple.com  2007-12-31 13:52 PDT -------
(In reply to comment #3)
> I went the other way around to make Database consistent with the other
> features, since Database ifdefs are already there, it's just a matter of adding
> a guard before including Database.h, which pretty much what the other features
> are doing (e.g. include xpath headers only if xpath is enabled). 

You say this is consistent with "the other features" but:

    1) The XPath header files like XPathEvaluator.h all have guards in the
header files.
    2) The SVG header files like SVGUseElement.h all have guards in the header
files.
    3) The XSLT header files like XSTLProcessor.h all have guards in the header
files.

While I'm sure that there are some extra #if statements that aren't needed
around some includes, I thinkt he pattern is that we put the guards in the
header files, not at the include sites.

I'd appreciate following one consistent approach. I think the current one is
the "in the header file" approach and should be changed to be consistently
that.

> Also, ideally we should be using DerivedSources.make but i had some issues with
> the existing makefile (e.g., vpath mangling, some make constructs do not work
> well with automake)

We need to do that work if possible. Putting the VPATH into a different file
would be fine.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.