[Webkit-unassigned] [Bug 16588] ResourceHandle::loadResourceSynchronously needs access to the FrameLoader

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16588


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18077|review?                     |review-
               Flag|                            |




------- Comment #3 from darin at apple.com  2007-12-30 23:48 PDT -------
(From update of attachment 18077)
If you are going to add a parameter, I suggest adding a Frame* rather than a
FrameLoader* to match ResourceHandle::create.

But since this is a layering violation, we should figure out a cleaner way to
do this.

Perhaps we should have a ResourceHandleFactory class and FrameLoaderClient can
return a ResourceHandleFactory. Then you'd use the ResourceHandleFactory to
make the ResourceHandle objects.

Or we could have a class with a name like ResourceLoadingContext, add a
FrameLoaderClient function that returns one, and we could pass that in to the
static members of ResourceHandle.

A typical client could implement both interfaces on the FrameLoaderClient and
it could just return "this". This might be enough allow us to remove the Frame*
parameter from both functions and remove the circular dependency.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.