[Webkit-unassigned] [Bug 16672] Number.toString does not throw exceptions like it should

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16672


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18180|review?                     |review+
               Flag|                            |




------- Comment #2 from sam at webkit.org  2007-12-30 00:37 PDT -------
(From update of attachment 18180)
This can be move up a little to return a little earlier.
+    double x = v->toNumber(exec);
+    if (isnan(x) || isinf(x))
+        return jsString(UString::from(x));

The change to object.cpp seems unrelated.

We should also test toString() with a fractional argument.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.