[Webkit-unassigned] [Bug 16643] number_object.cpp needs a bath

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16643





------- Comment #17 from sam at webkit.org  2007-12-28 19:07 PDT -------
(From update of attachment 18162)
There are two things that worry me about this patch.  The first is that a
different functionPrototype object can be set since you are no longer passing
in d()->functionPrototype but using the one off the execState (note, these may
be the same thing).  I am not sure this is an issue in practice, but it is a
concern.  The second issue is that by using the macro to make the class
declarations for the functions, an unused create function is also being
created.  I am going to think about these two issues a little and do a more
conclusive review later on tonight.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.