[Webkit-unassigned] [Bug 16596] ThreadSafeShared should be lock-free where possible

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16596


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18091|review?                     |review+
               Flag|                            |




------- Comment #4 from sam at webkit.org  2007-12-24 14:14 PDT -------
(From update of attachment 18091)
All in all, this seems great.  I do have a few nits though.

Typo.  This should be 1.7x.
+        This is a 1.7xs as fast as the lock-based implementation on x86 for a
single-threaded use

As discussed on IRC, #if PLATFORM(WIN_OS) might be better than #if
COMPILER(MSVC) for this.  And I think it would be clearer if you didn't reuse
the names InterlockedIncrement/InterlockedDecrement but rather used a new
inline function atomicIncrement/atomicDecrement that forwarded to those calls
on windows.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.