[Webkit-unassigned] [Bug 16584] New: [GTK] Need more fine grained return value for webkit_web_view_search_text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 23 05:39:44 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=16584

           Summary: [GTK] Need more fine grained return value for
                    webkit_web_view_search_text
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com


Sometimes it's useful to know not only if the search has succeeded, but whether
it had to wrap or not to do so. Epiphany, for instance, expects to get this
information from the search API (in order to update the UI with the wrap
information). The only way to do this now is to something like:

+  if (webkit_web_view_search_text (priv->web_view, priv->find_string,
priv->case_sensitive, forward, FALSE))
+  {
+    return EPHY_EMBED_FIND_FOUND;
+  }
+  else if (webkit_web_view_search_text (priv->web_view, priv->find_string,
priv->case_sensitive, forward, TRUE))
+  {
+    return EPHY_EMBED_FIND_FOUNDWRAPPED;
+  }
+  else
+    return EPHY_EMBED_FIND_NOTFOUND;

which is ugly.

It would be nice to return an enum value with { NOT_FOUND, FOUND, FOUND_WRAPPED
} possibilities.

Not sure how easy is to do this given the WebCore API, does not look trivial at
first sight though.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list