[Webkit-unassigned] [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15960


anyang.ren at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18053|review?                     |
               Flag|                            |
  Attachment #18053|0                           |1
        is obsolete|                            |
  Attachment #18063|                            |review?
               Flag|                            |




------- Comment #16 from anyang.ren at gmail.com  2007-12-22 18:02 PDT -------
Created an attachment (id=18063)
 --> (http://bugs.webkit.org/attachment.cgi?id=18063&action=view)
Proposed patch v2

Mitz, you're right.  Thanks for pointing that out.
I studied the code more and I think I understand the
code now.  The key is to study HTMLTokenizer::parseTag.

This patch should be correct, although it may not be the
best fix.

1. I believe that it is not necessary to test attr->value().isNull()
because in HTMLTokenizer::parseTag an attribute with no value is
added with:

  currToken.addAttribute(m_doc, attrName, emptyAtom, inViewSourceMode());

2. I use 'begin' because it equals 'i + 1', which is what I need.
If you think using 'i + 1' is clearer than 'begin', I can do that.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.