[Webkit-unassigned] [Bug 16573] Remove redundant calls to setPrototype in WebCore

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16573


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18057|review?                     |review-
               Flag|                            |




------- Comment #4 from sam at webkit.org  2007-12-22 16:41 PDT -------
(From update of attachment 18057)
Maciej r- this.  

"I think this introduces a GC hazard. If getting the prototype during
construction actually allocates it, then this could trigger a garbage
collection while an object is half-constructed, which will crash. The current
code is specifically designed to avoid this. You *could* get around this by
always passing in the prototype as a constructor argument and making the
generated code handle this. As long as it is allocated before you start
constructing the wrapper, there is no GC hazard."


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.