[Webkit-unassigned] [Bug 16558] Cairo WebCore Rendering Fails on arc drawing

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16558


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alp at atoker.com
           Keywords|                            |Cairo




------- Comment #2 from alp at atoker.com  2007-12-21 12:13 PDT -------
It turns out this fix provides the correct result, but looks like the direction
parameter was mis-named in WebKit.

CanvasRenderingContext2D.idl:

        void arc(in float x, in float y, in float radius, in float startAngle,
in float endAngle, in boolean clockwise)

HTML5 spec:

        void arc(in float x, in float y, in float radius, in float startAngle,
in float endAngle, in boolean anticlockwise);

It seems that based on
http://philip.html5.org/tests/canvas/suite/tests/results.html, test
2d.path.arc.angle.1, all browsers implement this parameter as "anticlockwise",
so the "clockwise" parameter name in WebKit might be a typo.

If this is right, the patch should be updated to correct the IDL,
CanvasRenderingContext2D.cpp, Path.h and also the three Path implementations to
fix the variable name.

I'd like to co-review this patch with another implementer of the canvas, either
CG or Qt.

Nice work!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.