[Webkit-unassigned] [Bug 16480] New: Document::completeURL should return a KURL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 14:23:17 PST 2007


           Summary: Document::completeURL should return a KURL
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: marv.decker at gmail.com

Document::completeURL returns either a String or a DepricatedString. Since the
output is really a URL, it should return a KURL instead.

This weirdness causes extra conversions that are not necessary and slow things
down. For example, in DocLoader::requestResource:
  KURL fullURL = m_doc->completeURL(url.deprecatedString());

This does a conversion to a KURL in completeURL, then does a conversion back to
a DeprecatedString, then converts back to a KURL. This is a whole extra parse
of the URL that's unnecessary. The String version is even sillier, since it has
to convert to and from a String before calling the DepricatedString version of

Some functions HTML* especially, need the string, but they should just get it
out of the KURL if they want it.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list