[Webkit-unassigned] [Bug 16464] Modify WebCore to use win32 thread primitives

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16464


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17965|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2007-12-17 10:24 PDT -------
(From update of attachment 17965)
 71 static const long MaxSemaphoreCount = static_cast<long>((~0u) >> 1);

I think it needs to be ~0UL rather than ~0U. And also there is no need for
parentheses there -- the precedence of the ~ operator is tighter than the >>
operator, and I think it's easier to read as is.

Patch has some tabs in it. We can't check in patches with tabs.

 115     unsigned was_gone=0;

Unused local variable here.

Otherwise looks good. r=me, although I'm a little nervous about the level of
testing that will be required to vet this on Windows with Safari.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.