[Webkit-unassigned] [Bug 16144] [GTK] Clipboard/ selection handling functions

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16144





------- Comment #10 from xan.lopez at gmail.com  2007-12-15 11:20 PDT -------
(In reply to comment #4)
> Created an attachment (id=17743)
 --> (http://bugs.webkit.org/attachment.cgi?id=17743&action=view) [edit]
> Update api, use new action signals
> 
> This is an updated version, taking the new action signals into account.
> 

I was halfway re-implementing this when alp pointed me to this bug, so a few
comments:

+        return frameData->frame->editor()->canCopy() ||
frameData->frame->editor()->canCopy();

missing the DTHML bit in the second one?

+        g_signal_emit_by_name(webView, "cut-clipboard");

Can we emit the signals with g_signal_emit? We are storing the identifiers
after all.

That's it, actually. Of course most functions are missing the docs, but I guess
you know that :)

I've checked the GtkClipboard stuff with Alp and I'd say we don't need an
explicit parameter for it at all. We'll double check with Owen, but I'd say
using GDK_SELECTION_CLIPBOARD internally should be good enough?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.