[Webkit-unassigned] [Bug 6129] Incomplete implementation of CSS 2.1 system colors

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=6129


proton at wiretapped.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17571|0                           |1
        is obsolete|                            |
  Attachment #17908|                            |review?
               Flag|                            |




------- Comment #21 from proton at wiretapped.net  2007-12-15 02:39 PDT -------
Created an attachment (id=17908)
 --> (http://bugs.webkit.org/attachment.cgi?id=17908&action=view)
Proposed patch

Use nextafter(256.0, 0.0), fixed the silly rounding issue. Thanks mitz!

Fixed a couple of comments Darin mentioned to be more clear hopeflly.

[NSGraphicsContext saveGraphicsState]; is both necessary and sufficient as far
as my reading of its documentation goes. "saveGraphicsState" is documented as
such: "This method sends the current graphics context a saveGraphicsState
message and pushes the context onto the per-thread stack." To match,
"restoreGraphicsState" does the reverse: "Pops a graphics context from the
per-thread stack, makes it current, and sends the context a
restoreGraphicsState message."

I believe this is necessary (we change the graphics state otherwise), and is
sufficient as we push/pop the appropriate graphics context.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.