[Webkit-unassigned] [Bug 16315] FindSafari Needs Path-Only Option

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16315


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17759|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-12-12 22:31 PDT -------
(From update of attachment 17759)
+    if (!printEnvironment)
+    {

Our code style guidelines say that the brace should be on the same line as the
if. See <http://webkit.org/coding/coding-style.html>.

It seems a little strange that if you pass both /printSafariLauncher and
/printSafariEnvironment, you only get the environment and don't get a launcher
at all. Perhaps /printSafariLauncher should override /printSafariEnvironment?

r- so that the above can be considered.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.