[Webkit-unassigned] [Bug 16406] [Gtk] JavaScriptCore needs -lpthread

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16406


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17858|                            |review-
               Flag|                            |




------- Comment #2 from mrowe at apple.com  2007-12-11 19:50 PDT -------
(From update of attachment 17858)
You should set the review flag to ? if you'd like your patch looked at for
review.  You should also include a description of your change in the ChangeLog
at JavaScriptCore/ChangeLog.  See http://webkit.org/coding/contributing.html
for more info.

The change looks fine to me.  It's not great to always add -lpthread as some
platforms may not use pthreads, but as JavaScriptCore makes the assumption that
they do when building multi-threaded I think it's fine for the meantime.

Marking as r- for now pending a ChangeLog entry.  Thanks for the patch!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.