[Webkit-unassigned] [Bug 16214] rename KURL to URL

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16214


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17837|review?                     |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2007-12-11 16:00 PDT -------
(From update of attachment 17837)
+        Scrub URL out of the tree in preparation of ranameing KURL to URL.

Renaming is spelled wrong here. Also "in preparation of" is not very good
English.

+        * WebCore.base.exp:
+        * bindings/js/kjs_events.cpp:
+        (WebCore::JSLazyEventListener::parseCode):

I don't think it is all that helpful to list all the files and functions when
the only change is renaming. It would be neat to list only files that have
interesting changes; something other than just renaming. Or we could just omit
the file list entirely. Or leave it as is, not sure.

1637          DeprecatedString dstUrl =
activeFrame->loader()->completeURL(DeprecatedString(args[0]->toString(exec))).url();
 1637         String dstUrl =
activeFrame->loader()->completeURL(args[0]->toString(exec)).deprecatedString();

This is strange. It's changed to call deprecatedString(), but the type of the
variable was changed to String!

48      return m_url.url().isNull();
 48     return m_url.deprecatedString().isNull();

We should probably add a KURL.isNull() for this. Not sure why I didn't.

What about platforms other than Mac and Windows.

r=me if you fix the things I mentioned above.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.