[Webkit-unassigned] [Bug 16385] Cleanup kjs_window

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16385


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17826|review?                     |review+
               Flag|                            |




------- Comment #3 from darin at apple.com  2007-12-10 14:20 PDT -------
(From update of attachment 17826)
Please run the sort-Xcode-project-file script on the project file.

+    // - dialogHide: trusted && WindowFeatures::boolFeature(features,
"dialoghide"), makes dialog hide when you print
+    // - help: WindowFeatures::boolFeature(features, "help", true), makes help
icon appear in dialog (what does it do on Windows?)
+    // - unadorned: trusted && WindowFeatures::boolFeature(features,
"unadorned");

Seems a little strange here. Global replace problem?

+static bool isSeparator(::UChar c)

I don't think you need the :: here. It was needed because of "using namespace
KJS".

+    {}

We usually put those braces on separate lines.

Where's the update to the .pro and .bkl files?

Otherwise looks fine.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.