[Webkit-unassigned] [Bug 16092] [GTK] Middle-mouse click should allow opening a URL in a new tab

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16092





------- Comment #5 from xan.lopez at gmail.com  2007-12-10 10:23 PDT -------
(In reply to comment #3)
> Created an attachment (id=17717)
 --> (http://bugs.webkit.org/attachment.cgi?id=17717&action=view) [edit]
> Patch
> 
> Second attempt, now passing a dictionary with the navigation-requested signal,
> which AFAICT is similar to what the Mac and Win ports do.
> 

Hi, so thinking out loud here. This looks pretty good to me, just one comment:

- Having to connect to the signal with _after looks really ugly to me, so I
think we should try something else instead. One solution is to decouple the
WebKitNavigationResponse from the fact of whether we want to block or not the
default handler. We can put the NavigationResponse in the signal arguments, and
make it return a boolean value (+ a boolean accumulator). If you want to block
the default handler, you simply return TRUE from your callback (and put the
response as something different than IGNORE I guess); otherwise, you return
FALSE.

Would this be feasible? How does it sound?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.