[Webkit-unassigned] [Bug 16371] Implement additional mouse cursors for Gtk

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16371


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17817|review?                     |review-
               Flag|                            |




------- Comment #3 from alp at atoker.com  2007-12-10 05:57 PDT -------
(From update of attachment 17817)
>-// FIXME: should find better GDK cursors for those than a generic GDK_LEFT_PTR
>+static GdkCursor* custom_cursor_new(CustomCursorType cursorType)

That can just be a TODO rather than a FIXME. The function should have a
camelCase name since this is WebCore code. (The names of the moz_ variables
don't matter so much, you can leave them as-is.)

>+
> const Cursor& verticalTextCursor()
> {
>-    return pointerCursor();
>+    static Cursor c = custom_cursor_new(CustomCursorVerticalText);
> }

This function is missing a 'return c;'

Could you write a ChangeLog entry, including a mention of where the code was
borrowed from?

Thanks!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.