[Webkit-unassigned] [Bug 14651] [CURL] didReceiveResponse() only called for HTTP loads

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14651


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17785|review?                     |review-
               Flag|                            |




------- Comment #3 from alp at atoker.com  2007-12-08 07:08 PDT -------
(From update of attachment 17785)
This bug fix works and is much needed.

I'm concerned about one thing in the implementation though:

writeCallback() is a hot path. We should first research if we can call
didReceiveResponse() earlier than writeCallback(). If this isn't an option, the
didReceiveResponse() call in writeCallback() needs to be made as lightweight as
possible -- perhaps a boolean check, rather than querying CURL for the
effective URL, constructing a KURL and updating the response again and again.
It only needs to be done once, right?

Think you could devise a lighter solution?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.