[Webkit-unassigned] [Bug 16351] New: FontFallbackList.h doesn't include wtf/PassRefPtr.h

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16351

           Summary: FontFallbackList.h doesn't include wtf/PassRefPtr.h
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: PC
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P3
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rob at cataclysm.cx


WebCore/platform/graphics/FontFallbackList.h uses PassRefPtr but doesn't
include wtf/PassRefPtr.h. This causes the following build error on my port:

In file included from
../../../WebCore/platform/graphics/FontFallbackList.cpp:30:
../../../WebCore/platform/graphics/FontFallbackList.h:47: error: 'PassRefPtr'
has not been declared
../../../WebCore/platform/graphics/FontFallbackList.h:47: error: expected ','
or '...' before '<' token
../../../WebCore/platform/graphics/FontFallbackList.cpp:45: error: prototype
for 'void
WebCore::FontFallbackList::invalidate(WTF::PassRefPtr<WebCore::FontSelector>)'
does not match any in class 'WebCore::FontFallbackList'
../../../WebCore/platform/graphics/FontFallbackList.h:47: error: candidate is:
void WebCore::FontFallbackList::invalidate(int)
make[1]: *** [tmp/FontFallbackList.o] Error 1

Adding the include resolves this. On my port nearly all my platform files are
currently no-op stubs, so I guess on other ports PassRefPtr.h is being brought
in elsewhere.

This at least occurs in r28509, but it doesn't seem to have been changed yet.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.