[Webkit-unassigned] [Bug 15528] svg_dynamic_cast should be removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 13:55:49 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=15528


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17780|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-12-07 13:55 PDT -------
(From update of attachment 17780)
 918                 if (node && node->isSVGElement())
 919                     textContent =
static_cast<SVGTextContentElement*>(node);

Why is isSVGElement() sufficient evidence that this is a SVGTextContentElement?
What guarantees that?

 83             target =
ownerDocument()->getElementById(SVGURIReference::getTarget(m_href));

Should just use document() here instead of ownerDocument(). ownerDocument() is
a lsower was to do the same thing.

 85             target = parentNode();
8686             while (target) {
8787                 if (target->nodeType() != ELEMENT_NODE)
8888                     target = target->parentNode();
8989                 else
9090                     break;
9191             }

This code seems unneeded to me. What node has a parent that's not an element?

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list