[Webkit-unassigned] [Bug 15669] Build with -DXP_UNIX and -lXt for GTK+/X11 port

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15669


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17676|review?                     |review+
               Flag|                            |




------- Comment #19 from darin at apple.com  2007-12-06 14:51 PDT -------
(From update of attachment 17676)
This seems good to me, except that I do not like the name of the new header
file.

I don't think the use of the term "proxy" in the title makes sense, and since
it's an internal file for WebCore, we don't have to use the "np" style naming.

 gtk-port {
+x11:plugins {
+    DEFINES += XP_UNIX
+}
+

Can this be indented so the nesting looks logical? I don't know the syntax of
these files, so I'm not sure.

r=me as-is, though -- those are really quibbles and this code is already pretty
messy


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.