[Webkit-unassigned] [Bug 16179] any attribute name start with a unicode which like #xx00(x could be any hex number[0-9a-f]) will cause HTMLTokenizer parse error.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 14:44:44 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=16179





------- Comment #11 from darin at apple.com  2007-12-06 14:44 PDT -------
(From update of attachment 17733)
Alexey informed me that there may be some security concerns with supporting
these additional characters in tag and attribute names. I don't know the
details yet. Alexey would you be willing to comment?

+        (WebCore::HTMLTokenizer::parseEntity): Handle unicode Entity Name by
using acsii version findentity.

"ASCII, not acssi". "version of findEntity", not "version findentity".

"Unicode", not "unicode".

Someone should fix the title of the bug; it no longer matches what's being
fixed here.

+                    // Since the maximum length of entity name only
+                    // can be 9, so one char array which is allocated
+                    // from stack, its length is 10, should be OK.
+                    // Also if we have illegal character, we treat it
+                    // as illegal entity name.

"maximum length is 9", not "maximum length can be 9"

"a single char array", not "one char array"

"on the stack", not "from stack"

"have an illegal character", not "have illegal character"

+                    char chTmpEntityNameBuffer[10];

We don't normally use type prefixes like "ch" in code.

+


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list