[Webkit-unassigned] [Bug 16185] jsRegExpCompile & match should not add implicit non-capturing bracket

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 1 10:40:25 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=16185





------- Comment #2 from darin at apple.com  2007-12-01 10:40 PDT -------
So I misunderstood this bug and added code so that jsRegExpCompile will omit
the outer bracket entirely when it's not needed.

This doesn't help the regexp-dna test in SunSpider much at all, because almost
all its regular expressions have "|" characters in them, which means they *do*
require the outer bracket.

Hence Eric's other suggestion, of optimizing match for this, really turns into
a sort of "unrolling" of the match function, which could indeed be helpful for
simple regular expressions.

I can't help thinking it's a little bit too specific to this particular test,
though. The more I look at the profile the more I realize it's a little bit too
biased toward this one particular set of regular expressions.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list