[Webkit-unassigned] [Bug 15669] Build with -DXP_UNIX and -lXt for GTK+/X11 port

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15669


alp at atoker.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17593|review?                     |review-
               Flag|                            |




------- Comment #15 from alp at atoker.com  2007-12-01 00:19 PDT -------
(From update of attachment 17593)
>+sub enableGtkPlugins()
>+{
>+    determineEnableGtkPlugins();
>+    return $enableGtkPlugins;
>+}
>+
>+sub determineEnableGtkPlugins()
>+{
>+    return if defined($enableGtkPlugins);
>+
>+    if (checkArgv("--disable-gtk-plugins")) {
>+        $enableGtkPlugins = 0;
>+    } else {
>+        $enableGtkPlugins = 1;
>+    }
>+}

My comment from the previous review was:

  Also, linking to Xt doesn't sound like the right thing to do in standard
  WebKit/GTK+ builds. There should be an optional switch to enable this kind of
  feature.

If you really want to contribute this as a standalone patch independent of the
actual code, can you be sure to change this to disabled by default? There's no
indication that linking to Xt is a good default, especially when nothing in the
codebase uses it yet.

Usually small build system changes like this are included in the same patch as
the actual implementation. It's difficult to review one or the other by itself
(there is no indication why X intrinsics is being linked at all here).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.