[Webkit-unassigned] [Bug 15079] Fails to build on arm (debian)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15079





------- Comment #3 from mh+webkit at glandium.org  2007-08-26 01:49 PDT -------
(In reply to comment #2)
> (From update of attachment 16121 [edit])
> Thanks for the patch! A couple of comments.
> 
> +#if   defined(arm) \
> +   || defined(__arm__)
> 
> You should just put these on the same line:
> 
> #if defined(arm) || defined(__arm__)

Well, I would have, if surrounding #if's weren't split over several lines. So
please tell me which way you really prefer ;)

> You'll need to create a ChangeLog entry using the prepare-ChangeLog. See
> <http://webkit.org/coding/contributing.html>.
> 
> You should also set the review flag to ? when uploading patches so that people
> know they need review.

Being used to mozilla's bugzilla, I assumed I needed a name for a reviewer,
which is why i didn't put the review flag.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.