[Webkit-unassigned] [Bug 15006] webkitdirs.pm contains too much code duplication for Qt and Gtk related stuff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 15:37:13 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=15006





------- Comment #8 from son.two at gmail.com  2007-08-24 15:37 PDT -------
(In reply to comment #7)
> This still doesn't answer what the reason for the change is besides an
> artificial desire to have to different things use the same function even though
> there is potential for them to need different behavior in the near future.

I think most likely both builds have a lot of in common: they  should be able
to 
choose qmake binary (--qmake), set some common params, read params from command 
line (--qmakearg), handle WEBKIT_FULLBUILD, run qmake and checks its result,
and, 
perhaps, something else.

So, current patch it attempt to write this in the code.  It might be not
perfect
but it is good enough for current situation.  Also every time someone will add 
something to either Qt or Gtk build, (s)he will be forced (by code) to think 
about adding this to another build.

Does this make sense for you?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list