[Webkit-unassigned] [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 23 16:31:54 PDT 2007


oliver at apple.com changed:

           What    |Removed                     |Added
  Attachment #16102|review?                     |review-
               Flag|                            |

------- Comment #26 from oliver at apple.com  2007-08-23 16:31 PDT -------
(From update of attachment 16102)
This causes a build failure on mac as KeyboardCodes.h does not exist on mac. 
This can be fixed by an ifdef around the include

Mac also fails due due selectionForEvent not being available in EditorMac -- i
suspect moving the Mac impl of Editor::handleKeypress into an ifdef'd block in
Editor.cpp, or remove the static modifier in Editor.cpp

On windows KeyboardCodes.h does not exit (ifdef fix again), and WebEditorClient
requires interpretKeyEvent -- which might be difficult to work around...
perhaps make it accesible from outside webcore? :-/

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list