[Webkit-unassigned] [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 18:41:51 PDT 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #16083|                            |review-
               Flag|                            |

------- Comment #2 from aroben at apple.com  2007-08-22 18:41 PDT -------
(From update of attachment 16083)
This patch looks fine (except for the lack of a ChangeLog entry (see
<http://webkit.org/coding/contributing.html>)), but I'd much rather see us
reduce code duplication rather than increase it.

(In reply to comment #0)

> The QT code is basically identical (neither the GTK nor QT code is specific to
> that platform) and a way should be found to share the GTK and QT code for this,
> but I'm leaving that as a separate issue.

I think Windows currently has the most complete code for this. We should work
on moving WebView::interpretKeyEvent and WebView::handleEditingKeyboardEvent
down into WebCore.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list