[Webkit-unassigned] [Bug 14899] !d->m_view->needsLayout() in Frame::paint() (Causes assert)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 14:51:44 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14899


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16065|review?                     |review+
               Flag|                            |




------- Comment #13 from darin at apple.com  2007-08-21 14:51 PDT -------
(From update of attachment 16065)
+    String width = getAttribute(widthAttr);
+    String height = getAttribute(heightAttr);

It'd be slightly more efficient to use const AtomicString& for these. This
would avoid a little bit of reference count churn. If we changed setAttribute
to take const AtomicString& we could also save re-hashing the string values to
make them Atomic again.

But that's very minor and I like the patch as-is.

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list