[Webkit-unassigned] [Bug 15006] webkitdirs.pm contains to much code duplication for Qt and Gtk related stuff

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15006


son.two at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16021|                            |review?
               Flag|                            |




------- Comment #1 from son.two at gmail.com  2007-08-19 07:38 PDT -------
Created an attachment (id=16021)
 --> (http://bugs.webkit.org/attachment.cgi?id=16021&action=view)
refactoring of webkitdirs.pm

To make buildQMakeGdkProject()/buildQMakeQtProject() as similar as possible
I've decided to only use "qmake" for build (before gtk port tried to use
qmake-qt4 first).  But since it is possible now to configure qmake which will
be used with "--qmake" cli option, it should not be a big problem.

Also I've decided to not place the check for directory ($project) for which
build is called in common area since I see no advantages from this.

Note, that I have not tested this with Qt build, freyther has agreed to do this
for me (thanks in advance btw :)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.