[Webkit-unassigned] [Bug 14967] Reduce wtf::Vector::operator[]() overloads to eliminate compiler warnings on Windows 64-bit

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14967


zerodpx at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15997|review-                     |review?
               Flag|                            |




------- Comment #16 from zerodpx at gmail.com  2007-08-18 00:17 PDT -------
(From update of attachment 15997)
I tested on a friend's Mac to ensure that the compile succeeded.  I wasn't
really able to see whether any new warnings were issued.  If someone else could
check that that would be great.  That said, this is how the STL does things, so
I suspect it's OK.

As mentioned previously, I'm having problems getting prepare-ChangeLog to work
for me.  Here's a ChangeLog entry someone landing this patch could use:

patch by Peter Kasting <zerodpx at gmail.org>, reviewed by Sam Weinig
http://bugs.webkit.org/show_bug.cgi?id=14967 part 2 - Eliminate all remaining
implicit conversions of wtf::Vector<T> to T*.  Where code was previously
checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.