[Webkit-unassigned] [Bug 14955] Implement getElementsByClassName

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14955





------- Comment #4 from catfish.man at gmail.com  2007-08-15 22:55 PDT -------
(In reply to comment #3)
> (From update of attachment 15991 [edit])
> I'm not sure the renaming of AtomicStringList is desirable. Perhaps
> ClassNameList should be a subclass of AtomicStringList that just adds the
> parseClassAttribute method? I could be convinced otherwise, though.

AtomicStringList effectively *is* already ClassNameList; it's used nowhere in
the code except to store lists of class names. Maciej has pointed out that it's
not even a particularly good structure to use for that, but fixing it is beyond
the scope of this patch.

> 
> It also seems like parseClassAttribute could be a static method that functions
> as a named constructor.
> 

Seems plausible. I'll try it out and see how it feels.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.