[Webkit-unassigned] [Bug 14967] Reduce wtf::Vector::operator[]() overloads to eliminate compiler warnings on Windows 64-bit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 15:04:42 PDT 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #15969|1                           |0
        is obsolete|                            |

------- Comment #3 from darin at apple.com  2007-08-14 15:04 PDT -------
(From update of attachment 15969)
-            if (!plugin->mimes)
+            if (plugin->mimes.isEmpty())

This looks like an actual minor bug fix, not just a compile fix.

-    if (!d->m_scheduledEvents)
+    if (d->m_scheduledEvents.isEmpty())

As does this.

The WebKitTools/Scripts/svn-create-patch change seems good, but doesn't belong
in this patch.

The safest way to land this change is to land all the obvious .data() changes
first, then look more closely at the smaller remaining bits.

I'd like to hear Maciej's thoughts on getting rid of the default conversion
functions. I was never a fan of them.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list